Fix the setSchema location logic in EML211 model #2775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- It now correctly sets or appends the xsi:schemaLocation to the `editorSchemaLocation` in appModel, rather than both `editorSerializationFormat` AND `editorSchemaLocation` - Add unit tests for setSchemaLocation - Use setSchemaLocation when making new EML doc rather than hardcoding the schemaLocation Fixes #1721
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the
setSchemamethod inEML211. It now correctly sets (or appends) thexsi:schemaLocationin the eml doc to theeditorSchemaLocationin AppModel. It was previously setting it toeditorSchemaLocationPLUSeditorSerializationFormat, resulting in 3 values forxsi:schemaLocation, making it invalid.I also added unit tests for
setSchemaLocation, including the case where an existing invalid schemaLocation already exists.I also updated the method that creates new EML to use the
setSchemaLocationmethod instead of than hardcoding the schemaLocation.Fixes #1721